Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dotnet): flexible nuget package file #42

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix(dotnet): flexible nuget package file #42

merged 1 commit into from
Sep 27, 2024

Conversation

omercnet
Copy link
Contributor

allow using this action to publish dotnet packages that do not start with Pulumi.*

@omercnet omercnet mentioned this pull request Sep 27, 2024
Merged
19 tasks
danielrbradley
danielrbradley approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

Happy to merge, once I've given others a chance to review.

@danielrbradley danielrbradley requested review from guineveresaenger and a team September 27, 2024 10:19
guineveresaenger
guineveresaenger approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @danielrbradley, this seems reasonable.

@omercnet
Copy link
Contributor Author

thanks guys - is someone able to merge?

@danielrbradley danielrbradley merged commit 48a8354 into pulumi:main Sep 27, 2024
1 check passed
@danielrbradley
Copy link
Member

Done! 🚀

@ringods ringods mentioned this pull request Dec 15, 2024
Closed
@pulumi-bot
Copy link

This PR has been shipped in release v0.0.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guineveresaenger guineveresaenger guineveresaenger approved these changes

@danielrbradley danielrbradley danielrbradley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omercnet @danielrbradley @pulumi-bot @guineveresaenger