BREAKING: Remove installing tools #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave it to the caller to install the prerequisite tools as additional options might want to be used for caching etc. - Remove tool install steps. - Remove all version inputs. - Add tool pre-requisites to the documentation.
blampe
approved these changes
Jun 26, 2024
These should be performed by the caller rather that within the action so that the options can be customised.
danielrbradley
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Jun 27, 2024
Re-use our own tool setups which can include additional options for caching rather than duplicating the setup logic into the publishing action. This depends on first merging: - pulumi/pulumi-package-publisher#32 - #1003 This PR assumes that `pulumi/pulumi-package-publisher` will then be published as `v0.0.19` (the next version).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave it to the caller to install the prerequisite tools as additional options might want to be used for caching etc.
The other half of the work to integrate this breaking change into ci-mgmt is in: