hotfix: NPM install lacks install-pulumi-plugin.js #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFriel
requested review from
mikhailshilkov,
a team and
guineveresaenger
and removed request for
a team
AaronFriel
added a commit
to pulumi/pulumi-github
that referenced
this pull request
Jun 17, 2023
Running `npm install` fails due to a missing script in the packaged tarball. This updates the pulumi-package-publisher to include this script, prior to wider rollout. If this succeeds, we'll update pulumi-package-publisher and then roll out to all providers. See: - pulumi/pulumi-package-publisher#11 - pulumi/pulumi-package-publisher#10 - pulumi/pulumi-azure#1301
EvanBoyle
approved these changes
Jun 17, 2023
AaronFriel
force-pushed
the
friel/hotfix-npm-publish
branch
from
295ac32 to
f143cb7
Compare
Fixes #10 This hotfix is intended to substitute for a longer term fix in pulumi/pulumi#13195. This allows us to update our publishing workflows with a fixed NPM package.
AaronFriel
force-pushed
the
friel/hotfix-npm-publish
branch
from
f143cb7 to
c1056fa
Compare
AaronFriel
added a commit
to pulumi/pulumi-github
that referenced
this pull request
Jun 17, 2023
Running `npm install` fails due to a missing script in the packaged tarball. This updates the pulumi-package-publisher to include this script, prior to wider rollout. If this succeeds, we'll update pulumi-package-publisher and then roll out to all providers. See: - pulumi/pulumi-package-publisher#11 - pulumi/pulumi-package-publisher#10 - pulumi/pulumi-azure#1301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
This hotfix is intended to substitute for a longer term fix in pulumi/pulumi#13195. This allows us to update our publishing workflows with a fixed NPM package.
This fix is trialed here:
If that works, we'll roll this out to all providers via ci-mgmt and release new versions of packages where the NPM script was omitted. (That list is to be determined.)
Update:
This PR was tested with the GitHub provider v5.12.0-beta.1: