-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade terraform-provider-okta to v4.0.0 #309
Upgrade terraform-provider-okta to v4.0.0 #309
Conversation
Does the PR have any schema changes?Found 163 breaking changes: Maintainer note: consult the runbook for dealing with any breaking changes. |
Lint failure. Would you like to hand over @guineveresaenger or continuing fixing this? |
Does the PR have any schema changes?Found 163 breaking changes: Maintainer note: consult the runbook for dealing with any breaking changes. |
Having a look at the test failures. |
Does the PR have any schema changes?Found 163 breaking changes: Maintainer note: consult the runbook for dealing with any breaking changes. |
Does the PR have any schema changes?Found 163 breaking changes: Maintainer note: consult the runbook for dealing with any breaking changes. |
Does the PR have any schema changes?Found 163 breaking changes: Maintainer note: consult the runbook for dealing with any breaking changes. |
Does the PR have any schema changes?Found 163 breaking changes: Maintainer note: consult the runbook for dealing with any breaking changes. |
Unfortunately tagging tricks do not work, on CI pulumictl still attempts to version things as 3.x.x. Need to resort to VERSION_PREFIX to coerce it to compute correct 4.x.x versions. One sec. |
…208' into upgrade-terraform-provider-terraform-provider-okta-to-v4.0.0
Does the PR have any schema changes?Found 163 breaking changes: Maintainer note: consult the runbook for dealing with any breaking changes. |
Does the PR have any schema changes?Found 163 breaking changes: Maintainer note: consult the runbook for dealing with any breaking changes. |
I've found a lot of the breaking changes in okta/terraform-provider-okta#1338 For example
For others note "deprecated" in the name:
|
This would be almost good to go but I notice that
We have no acceptance tests running. Unfortunately that is a blocker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#312 - need to figure out this first
Does the PR have any schema changes?Found 163 breaking changes: Maintainer note: consult the runbook for dealing with any breaking changes. |
I updated the repository secrets with a new token on our okta account, and rerunning the tests. |
Does the PR have any schema changes?Found 163 breaking changes: Maintainer note: consult the runbook for dealing with any breaking changes. |
Test failure, perhaps a typo in configuration? |
Test is running and passes. It was a matter of a deleted token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
This PR was generated via
$ upgrade-provider pulumi/pulumi-okta --major
.Updating major version from 3.23.0 to 4.0.0.
Upgrading terraform-provider-okta from 3.46.0 to 4.0.0.
Upgrading pulumi-terraform-bridge from v3.44.3 to v3.47.2.
Fixes #301