Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch appliance vlans #110

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

VenelinMartinov
Copy link
Contributor

fixes #100 with a patch while we resolve the bridge issue: pulumi/pulumi-terraform-bridge#2170

Again as with #109 the properties shouldn't really be computed as the resource does not work if they are not set.

@VenelinMartinov VenelinMartinov requested review from mjeffryes and a team July 12, 2024 16:51
@VenelinMartinov VenelinMartinov changed the base branch from main to vvm/patch_vlan_names July 12, 2024 16:52
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@VenelinMartinov VenelinMartinov added the needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 label Jul 12, 2024
Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging on the basis of @VenelinMartinov's manual testing

@VenelinMartinov VenelinMartinov merged commit ec43672 into vvm/patch_vlan_names Jul 12, 2024
24 checks passed
@mjeffryes mjeffryes added this to the 0.107 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meraki.networks.ApplianceVlans not updating reservedIpRanges correctly
2 participants