Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs format patch #627

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Remove docs format patch #627

merged 1 commit into from
Dec 9, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 9, 2024

This improves the quality of our docs in this repository by a lot. The original docs patch
was inserted because the bridge didn't pick-up the docs path that keycloak was using. It
now does.

It also unblocks #626.

@iwahbe iwahbe requested a review from a team December 9, 2024 10:17
@iwahbe iwahbe self-assigned this Dec 9, 2024
@iwahbe iwahbe enabled auto-merge (squash) December 9, 2024 10:18
@iwahbe iwahbe disabled auto-merge December 9, 2024 10:18
@iwahbe iwahbe force-pushed the iwahbe/fix-patch-format branch from bee596c to c7a693e Compare December 9, 2024 10:18
@iwahbe iwahbe enabled auto-merge (rebase) December 9, 2024 10:18
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@iwahbe iwahbe force-pushed the iwahbe/fix-patch-format branch from c7a693e to 8f2ecbe Compare December 9, 2024 10:28
@iwahbe iwahbe changed the title Fix patch format Remove docs format patch Dec 9, 2024
This improves the quality of our docs in this repository by a lot. The original docs patch
was inserted because the bridge didn't pick-up the docs path that keycloak was using. It
now does.

It also unblocks #626.
@iwahbe iwahbe force-pushed the iwahbe/fix-patch-format branch from 8f2ecbe to 7e02c63 Compare December 9, 2024 10:29
Copy link

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@iwahbe iwahbe merged commit 77135ef into master Dec 9, 2024
23 checks passed
@iwahbe iwahbe deleted the iwahbe/fix-patch-format branch December 9, 2024 10:37
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v5.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants