Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Fix indentation in yaml reference for explicit providers #4233

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

VenelinMartinov
Copy link
Contributor

Description

Small fix in the yaml reference - was missing the resources declaration.

Checklist:

  • I have reviewed the style guide.
  • If blogging, I have reviewed the blogging guide.
  • I have manually confirmed that all new links work.
  • I added aliases (i.e., redirects) for all filename changes.
  • If making css changes, I rebuilt the bundle.

@VenelinMartinov VenelinMartinov requested a review from a team April 26, 2024 11:16
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 5d782a6 is ready! 🎉

http://pulumi-hugo-origin-pr-4233-5d782a61.s3-website.us-west-2.amazonaws.com.

Copy link
Contributor

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the preceding sentence needs fixing up too. This look okay?

@@ -135,7 +135,8 @@ resources:
To create an explicit provider instance, preferably with a specific version, use the [`resources`](#resources) section and prefix the name of the provider with `pulumi:providers` which will the value of the `type` property.
Copy link
Contributor

@cnunciato cnunciato Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To create an explicit provider instance, preferably with a specific version, use the [`resources`](#resources) section and prefix the name of the provider with `pulumi:providers` which will the value of the `type` property.
To create an explicit provider instance, preferably with a specific version, use the [`resources`](#resources) section to declare a `provider`, prefixing the `type` with `pulumi:providers`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting! I edited it as:

For the type property, prefix the name of the provider with pulumi:providers.

I believe this is slightly more clear but feel free to disagree, happy to go with your original suggestion.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit b6a582a is ready! 🎉

http://pulumi-hugo-origin-pr-4233-b6a582ad.s3-website.us-west-2.amazonaws.com.

@VenelinMartinov VenelinMartinov merged commit 2dd1def into master Apr 26, 2024
2 checks passed
@VenelinMartinov VenelinMartinov deleted the VenelinMartinov-patch-1 branch April 26, 2024 20:12
Copy link

Site previews for this pull request have been removed. ✨

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants