Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-github to v5.37.0 #449

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

pulumi-bot
Copy link
Contributor

This PR was generated via $ upgrade-provider pulumi/pulumi-github --kind=all.


@pulumi-bot pulumi-bot self-assigned this Sep 20, 2023
@pulumi-bot pulumi-bot requested review from lukehoban and a team September 20, 2023 16:13
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 5 breaking changes:

Types

  • 🟢 "github:index/OrganizationRulesetBypassActor:OrganizationRulesetBypassActor": required: "bypassMode" property has changed to Required
  • "github:index/OrganizationRulesetConditionsRepositoryName:OrganizationRulesetConditionsRepositoryName":
    • 🟡 properties: "inlcudes" missing
    • required:
      • 🟢 "includes" property has changed to Required
      • 🟢 "inlcudes" property is no longer Required
  • 🟢 "github:index/RepositoryRulesetBypassActor:RepositoryRulesetBypassActor": required: "bypassMode" property has changed to Required
    No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0
Copy link
Member

t0yv0 commented Sep 20, 2023

This LGTM - @lukehoban is it correct to assume we don't need your ack here given that upstream is from GitHub org itself? I thought so but now a bit concerned about failing security/snyk checks that I can't look inside of, so I will wait for an ack.

@mikhailshilkov
Copy link
Member

@t0yv0 the current guidance is that we need @lukehoban review for all provider updates

@t0yv0
Copy link
Member

t0yv0 commented Sep 21, 2023

Got it. The previous update is on master but unreleased. No harm done.

@t0yv0 t0yv0 enabled auto-merge (squash) September 22, 2023 19:47
@t0yv0 t0yv0 merged commit 182415c into master Sep 22, 2023
15 checks passed
@t0yv0 t0yv0 deleted the upgrade-terraform-provider-github-to-v5.37.0 branch September 22, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants