Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-github to v5.34.0 #417

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Aug 28, 2023

This PR was generated via $ upgrade-provider pulumi/pulumi-github.


@iwahbe iwahbe self-assigned this Aug 28, 2023
@iwahbe iwahbe requested review from lukehoban and a team August 28, 2023 22:19
@github-actions
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • index/codespacesOrganizationSecretRepositories.CodespacesOrganizationSecretRepositories
  • index/repositoryDependabotSecurityUpdates.RepositoryDependabotSecurityUpdates

Maintainer note: consult the runbook for dealing with any breaking changes.

@mjeffryes
Copy link
Member

I'm curious why you had to manually create this upgrade; shouldn't the bot have created it for us?

@iwahbe
Copy link
Member Author

iwahbe commented Aug 28, 2023

I'm curious why you had to manually create this upgrade; shouldn't the bot have created it for us?

Good question. A new resource didn't have any documentation, which is set to fail make tfgen. Accepting that there is no upstream docs was done in resources.go.

In general, if your curious why there wasn't a CI generated PR, look for changes in provider/ or patches/.

@iwahbe iwahbe merged commit 3eb4861 into master Aug 29, 2023
@iwahbe iwahbe deleted the upgrade-terraform-provider-github-to-v5.34.0 branch August 29, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-github to v5.34.0
3 participants