-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs and enable reliable multi-stage caching #601
Conversation
@iwahbe It looks like the build fails because the new example references the AWS provider, which isn't installed. I seem to recall there's a PCL binder option to allow it to ignore failures like this, but I don't remember if that works with YAML. Should I modify |
SkipResourceTypechecking might solve the problem here, but the aws references could be wrong (due to missing global analysis). I would make sure we call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes, but otherwise this is great!
if err != nil { | ||
continue | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this block as past! us were smart and we should be already logged in if cacheImages is set - we can use regAuth for the call to pullDockerImage
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think as it's written it'll help us implement #497 when we get to it, no harm in keeping the code as it is?
* Remove contractions for accessibility * Move Hugo shortcode wrapping into generate.go Co-authored-by: Guinevere Saenger <[email protected]>
8f3a313
to
0c13d9d
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
0c13d9d
to
98299b7
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you!
In this PR, we adopt a workaround for Buildkit caching described in these upstream issues:
docker-container
moby/buildkit#2274The workaround is simple: pull images referenced in
--cache-from
before building.Accordingly, this PR adds an example to the docs for enabling multi-stage build caching, and addresses related documentation issues:
Image
to use Buildkit inline caching #592destroy
#588Documentation fixes rely on and uses an upstream merged commit for tfgen, following the merge of: