Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout improved example converter #1064

Merged
merged 4 commits into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .ci-mgmt.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ makeTemplate: bridged
docsCmd: "cd provider/pkg/docs-gen/examples/ && go run generate.go ./yaml ./"
hybrid: true
plugins:
- name: terraform
version: "1.0.16"
kind: converter

- name: aws
version: "6.8.0"
team: ecosystem
Expand All @@ -34,3 +38,4 @@ actions:
uses: webfactory/[email protected]
with:
ssh-private-key: ${{ secrets.PRIVATE_SSH_KEY_FOR_DIGITALOCEAN }}
pulumiConvert: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this file even exists -- I'm assuming it takes precedence over https://github.com/pulumi/ci-mgmt/blob/master/provider-ci/providers/docker/config.yaml? Ugh.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this file here is the source of truth, and if you run make ci-mgmt it resyncs derivative files to it.

3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ VERSION := $(shell pulumictl get version)
JAVA_GEN := pulumi-java-gen
TESTPARALLELISM := 10
WORKING_DIR := $(shell pwd)
PULUMI_CONVERT := 0
PULUMI_CONVERT := 1

development: install_plugins provider build_sdks install_sdks

Expand Down Expand Up @@ -114,6 +114,7 @@ install_nodejs_sdk:
install_plugins: export PULUMI_HOME := $(WORKING_DIR)/.pulumi
install_plugins: export PATH := $(WORKING_DIR)/.pulumi/bin:$(PATH)
install_plugins: .pulumi/bin/pulumi
.pulumi/bin/pulumi plugin install converter terraform 1.0.16
.pulumi/bin/pulumi plugin install resource aws 6.8.0

lint_provider: provider
Expand Down
140 changes: 70 additions & 70 deletions provider/cmd/pulumi-resource-docker/schema.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion scripts/upstream.sh
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ end_rebase() {

rm patches/*.patch
cd upstream
git format-patch local -o ../patches --zero-commit --no-signature --no-stat
git format-patch local -o ../patches --zero-commit --no-signature --no-stat --no-numbered
cd ..
rm rebase-in-progress
apply "$1"
Expand Down
5 changes: 3 additions & 2 deletions sdk/dotnet/Container.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions sdk/dotnet/GetRegistryImage.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions sdk/dotnet/GetRemoteImage.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion sdk/dotnet/Network.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 0 additions & 29 deletions sdk/dotnet/Plugin.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 0 additions & 31 deletions sdk/dotnet/RegistryImage.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions sdk/dotnet/RemoteImage.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion sdk/dotnet/Volume.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions sdk/go/docker/container.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions sdk/go/docker/getRegistryImage.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions sdk/go/docker/getRemoteImage.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion sdk/go/docker/network.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 0 additions & 36 deletions sdk/go/docker/plugin.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading