Fix typo: Match new "id" name to delegated ID field
#672
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we had:
```
"id": {Name: "monitorId"},
},
ComputeID: tfbridge.DelegateIDField(
"monitorID",
"databricks",
"https://github.com/pulumi/pulumi-databricks",
```
Note that the name assigned to `"id"` (`"monitorId"`) doesn't match the name of the field
we told `tfbridge.DelegateIDField` to find the ID in (`"monitorID"`). These **must** match
for `tfbridge.DelegateIDField` to work.
Fixes #669
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
VenelinMartinov
approved these changes
Dec 12, 2024
iwahbe
added
the
needs-release/patch
|
This PR has been shipped in release v1.56.2. |
github-actions
bot
removed
the
needs-release/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we had:
Note that the name assigned to
"id"("monitorId") doesn't match the name of the field we toldtfbridge.DelegateIDFieldto find the ID in ("monitorID"). These must match fortfbridge.DelegateIDFieldto work.Fixes #669