Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic on remote connection errors #530

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix panic on remote connection errors #530

wants to merge 1 commit into from

Commits on Sep 5, 2024

  1. Fix panic on remote connection errors 

    There was a panic in remote.dialWithRetry() on context cancellation,
e.g. when timeout that was specified by pulumi.Timeouts() passed to
remote.NewCommand() exceeded.

retry.Until() when the context is cancelled returns: ok = false, data = nil, err = nil;
so if we try to cast data to T, we get panic:
   > interface conversion: interface {} is nil, not T

We can cast data to T in remote.dialWithRetry(), not only when err returned
from retry.Until() is nil, but also when ok is true.
    @waketheashes
    waketheashes committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9c0182f View commit details
    Browse the repository at this point in the history