Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve provider integration tests #1678

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

danielrbradley
Copy link
Member

  • Tidy up function naming.
  • Make baseline version an argument.
  • Use attachment & extract setup method.

- Use attachment for better debugging.
- Allow us to test upgrading from different versions.
@danielrbradley danielrbradley self-assigned this Dec 13, 2024
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.00%. Comparing base (fdabfa4) to head (f6d59ca).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1678       +/-   ##
===========================================
+ Coverage    0.00%   25.00%   +25.00%     
===========================================
  Files           3        3               
  Lines           8        8               
===========================================
+ Hits            0        2        +2     
+ Misses          8        6        -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielrbradley danielrbradley requested a review from a team December 13, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant