Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storage container replacement during upgrade under PRC #2331

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Fix storage container replacement during upgrade under PRC #2331

merged 2 commits into from
Aug 19, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Aug 19, 2024 •
edited
Loading

This prevents the storage Container resource from being replaced under PRC when upgrading the provider.

Note this is an intentional divergence from the TF provider but the TF behaviour here is bad and we are not taking up a patch for this.

Note this is already covered by Test_storage, see failure in https://github.com/pulumi/pulumi-azure/actions/runs/10178181276/job/28152031872?pr=2306

Similar to #2325

fixes #2330
stacked on #2306

@VenelinMartinov VenelinMartinov mentioned this pull request Aug 19, 2024
Closed
3 tasks
@github-actions GitHub Actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@VenelinMartinov VenelinMartinov changed the base branch from master to vvm/enable_prc_by_default August 19, 2024 12:53
iwahbe
iwahbe approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is already under test, it looks good to me.

@VenelinMartinov VenelinMartinov merged commit 83f8726 into vvm/enable_prc_by_default Aug 19, 2024
6 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/fix_storage_container_replacement branch August 19, 2024 14:14
@VenelinMartinov VenelinMartinov mentioned this pull request Aug 19, 2024
Merged
VenelinMartinov added a commit that referenced this pull request Aug 19, 2024
@VenelinMartinov
Enable PRC by default in pulumi-azure (#2306)
044395a 
Enables PlanResourceChange by default in pulumi-azure.

Part of pulumi/pulumi-terraform-bridge#1785

Also contains #2325
Also contains #2331

fixes #2322
fixes #2323
fixes #2330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas11 thomas11 thomas11 left review comments

@iwahbe iwahbe iwahbe approved these changes

@t0yv0 t0yv0 Awaiting requested review from t0yv0

@danielrbradley danielrbradley Awaiting requested review from danielrbradley

@guineveresaenger guineveresaenger Awaiting requested review from guineveresaenger

Assignees

@VenelinMartinov VenelinMartinov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage Container replaced during upgrade under PRC
3 participants
@VenelinMartinov @thomas11 @iwahbe