Test shim as a normal unit test #4917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
approved these changes
Dec 12, 2024
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
t0yv0
reviewed
Dec 12, 2024
| ) | ||
|
|
||
| // This checks that any runtime checks in the underlying provider (with patches) are passed. | ||
| func TestProviderShim(t *testing.T) { |
|
Upstream failure is unrelated |
|
This PR has been shipped in release v6.65.0. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
go_test_shimjob defined inextraTestsby making it a normal provider unit test instead of something that needs to be run as part of upstream.We currently attempt to upload coverage as part of this test, but it doesn't work. pulumi/ci-mgmt#1224 will start uploading unit test coverage by default.