Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lambda Runtime enum #4880

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

flostadler
Copy link
Contributor

@flostadler flostadler commented Dec 4, 2024

Updates the lambda runtime enum according to the AWS docs: https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

We should look into automating this in the future: #4881
Fixes #4875

@flostadler flostadler requested review from t0yv0, corymhall and a team December 4, 2024 11:24
@flostadler flostadler self-assigned this Dec 4, 2024
provider/types.go Show resolved Hide resolved
provider/types.go Show resolved Hide resolved
Copy link

github-actions bot commented Dec 4, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I miss the deprecations in my original review or did you force push it after @flostadler

Sorry about the noise in case I missed it!

@flostadler
Copy link
Contributor Author

Did I miss the deprecations in my original review or did you force push it after @flostadler

Sorry about the noise in case I missed it!

No worries! I didn't force push, but it's always good to double check (way better than shipping a regression! 😁)

@flostadler flostadler merged commit 05c63ab into master Dec 4, 2024
33 checks passed
@flostadler flostadler deleted the flostadler/update-lambda-runtimes branch December 4, 2024 14:15
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (375329a) to head (9012c9e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff       @@
##   master   #4880   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.64.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS lambda Nodejs 22 runtime is missing
3 participants