Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestIMDSAuth test by increasing root volume size #4781

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

flostadler
Copy link
Contributor

@flostadler flostadler commented Nov 15, 2024

The TestIMDSAuth was broken because the default 8GB root volume was not enough anymore to fit pulumi and the aws provider.
This change fixes that.

Also adds disk cleaning to the upstream test steps

Fixes #4780

@flostadler flostadler self-assigned this Nov 15, 2024
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8GB root volume was not enough anymore to fit pulumi and the aws provider.

🤯

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Did the provider size increase drastically recently?

@flostadler
Copy link
Contributor Author

Hm. Did the provider size increase drastically recently?

Yeah it did: #4383

@flostadler flostadler merged commit 754a01f into master Nov 15, 2024
33 checks passed
@flostadler flostadler deleted the flostadler/fix-imds-test branch November 15, 2024 16:46
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.60.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test TestIMDSAuth/IDMSv2 broken
4 participants