Upstream v5.71.0 #4638
Merged
Upstream v5.71.0 #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
commented
Oct 14, 2024
| Computed: true, | ||
| names.AttrTags: tftags.TagsAttribute(), | ||
| - names.AttrTagsAll: tftags.TagsAttributeComputedOnly(), | ||
| + names.AttrTagsAll: tftags.TagsAttribute(), |
There was a problem hiding this comment.
Patch conflict here. I think simply the surrounding code changed upstream, so all this does is makes sure the patch still cleanly applies, while the real edits are removing ComputedOnly.
t0yv0
commented
Oct 14, 2024
| }, | ||
| }, | ||
| names.AttrTags: tftags.TagsAttribute(), | ||
| - names.AttrTagsAll: tftags.TagsAttributeComputedOnly(), |
Does the PR have any schema changes?Found 3 breaking changes: Resources
Types
New resources:
New functions:
Maintainer note: consult the runbook for dealing with any breaking changes. |
flostadler
reviewed
Oct 15, 2024
|
@flostadler we didn't quite always align the Pulumi ID with TF import IDs but it is safe to do so and makes sense, I implemented your suggestion, PTAL. |
flostadler
approved these changes
Oct 15, 2024
| ) (resource.ID, error) { | ||
| // The ${name}:${restoreTestingPlanName} is the format used by TF import, so we are going to use it for | ||
| // the Pulumi ID as well. | ||
| return attrWithSeparator(state, ":", "name", "restoreTestingPlanName"), nil |
There was a problem hiding this comment.
I wasn't even that worried about the separator, mostly the order. But it's fine nevertheless!
|
This PR has been shipped in release v6.56.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream is updated to v5.71.0
New resources:
backup/restoreTestingPlan.RestoreTestingPlan
backup/restoreTestingSelection.RestoreTestingSelection
datazone/userProfile.UserProfile
pinpoint/smsvoicev2ConfigurationSet.Smsvoicev2ConfigurationSet
route53/profilesAssociation.ProfilesAssociation
route53/profilesProfile.ProfilesProfile
route53/profilesResourceAssociation.ProfilesResourceAssociation
New functions:
amp/getDefaultScraperConfiguration.getDefaultScraperConfiguration
bedrock/getInferenceProfile.getInferenceProfile
bedrock/getInferenceProfiles.getInferenceProfiles
elasticache/getServerlessCache.getServerlessCache
route53/getProfilesProfiles.getProfilesProfiles
Fixes #4630