Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-aws upon release of new Terraform AWS Resource(issue #34982) #3160

Closed
zbuchheit opened this issue Dec 19, 2023 · 10 comments
Assignees
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). customer/feedback Feedback from customers customer/lighthouse Lighthouse customer bugs kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@zbuchheit
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Upgrade Pulumi-AWS Provider upon the release of [New Resource]: Add IAM cluster access management API resources to add IAM cluster access management API resources

Affected area/feature

@zbuchheit zbuchheit added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team customer/feedback Feedback from customers customer/lighthouse Lighthouse customer bugs labels Dec 19, 2023
@t0yv0
Copy link
Member

t0yv0 commented Dec 20, 2023

Thank you for filing this @zbuchheit

We're currently on par with upstream at 5.31.0 per #3159 and I believe our processes will kick in to ensure a release shortly after upstream releases this. We'll let you know here when this is ready

@t0yv0 t0yv0 added awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). and removed needs-triage Needs attention from the triage team labels Dec 20, 2023
iwahbe added a commit to pulumi/ci-mgmt that referenced this issue Dec 20, 2023
This avoids accidental upgrades such as those caused by
pulumi/pulumi-aws#3160.
iwahbe added a commit to pulumi/ci-mgmt that referenced this issue Dec 20, 2023
This avoids accidental upgrades such as those caused by
pulumi/pulumi-aws#3160.
iwahbe added a commit to pulumi/ci-mgmt that referenced this issue Dec 20, 2023
This avoids accidental upgrades such as those caused by
pulumi/pulumi-aws#3160.


--- 

I will test before merging:

- Does not fire on user (non `Pulumi-bot` issues):
https://github.com/pulumi/pulumi-linode/actions/runs/7279564493
- Does fire on `Pulumi-bot` issues:
https://github.com/pulumi/pulumi-linode/actions/runs/7279555195
@zbuchheit
Copy link
Author

@t0yv0 It looks like the upstream issue was completed but there is an interesting note in the comments.

Access entry requires a lot more params, most of them optional, compared to what's requested here. I.e.:

resource aws_eks_access_entry example {
  iam_role = arn:aws:iam::012345678910:role/MyRole
  username = "my-other-username" (optional)
  kubernetes_groups = "my-other-group" (optional)
  type = "" (optional, options are: 
    EC2_LINUX
    EC2_WINDOWS
    FARGATE_LINUX
    STANDARD
  )
}
As entries for node bootstrap also need to be supported. Same with authenticationMode, which needs a note that it's a one way street if you go from API_AND_CONFIG_MAP to API. And that should be a new optional param within aws_eks_cluster imho. Wit the default of CONFIG_MAP. That way it's backwards compatible.

Here's a good doc on what is covered by this change: https://github.com/aws/containers-roadmap/issues/185#issuecomment-1863025784

@t0yv0
Copy link
Member

t0yv0 commented Jan 18, 2024

Very interesting. Unfortunately our matching release is currently blocked on recovering legacy bucket support, it's next on my list! I'll let you know and double-check / test out the aws_eks_access_entry resource once I have a build.

@zbuchheit
Copy link
Author

@t0yv0 fyi on the upstream issue there are comments on the PR that suggest it wasn’t implemented correctly and is still missing things.

@zbuchheit
Copy link
Author

PR 35391 addresses the issues I mentioned.

@t0yv0
Copy link
Member

t0yv0 commented Jan 23, 2024

Checking up on this @zbuchheit , we caught up with the latest upstream release but the fix in question is https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#5340-unreleased still unreleased - will be coming in 5.34.0 upstream or some such new version. I'll update here when that is released and we catch up on our side.

@zbuchheit
Copy link
Author

5.34.0 appears to be released now

@t0yv0
Copy link
Member

t0yv0 commented Jan 26, 2024

CC @guineveresaenger --^ thank you

@iwahbe
Copy link
Member

iwahbe commented Jan 30, 2024

5.34.0 has been released.

@iwahbe iwahbe closed this as completed Jan 30, 2024
@zbuchheit
Copy link
Author

thank you all involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). customer/feedback Feedback from customers customer/lighthouse Lighthouse customer bugs kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants