Test: Upgrade pulumi/{pkg,sdk} to 202491bfea6af05adc505d41a5166e7db9bbdee3 #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
reviewed
Oct 27, 2023
| @@ -135,7 +135,7 @@ require ( | |||
| github.com/pkg/term v1.1.0 // indirect | |||
| github.com/pmezard/go-difflib v1.0.0 // indirect | |||
| github.com/pulumi/esc v0.5.6 // indirect | |||
| github.com/pulumi/pulumi/sdk/v3 v3.90.1 // indirect | |||
| github.com/pulumi/pulumi/sdk/v3 v3.91.0 // indirect | |||
There was a problem hiding this comment.
I wonder it made this change but I guess replace takes care of it anyway. Perhaps tidy is not good after a replace? Not sure; we do want to chase down minor indirect dependencies automatically though. This is probably as good as it gets. CC @iwahbe
There was a problem hiding this comment.
If we don't tidy then go complains that it can't parse the go.mod file, since most of go's resolvers don't handle SHAs as versions correctly.
I think this is good enough.
t0yv0
reviewed
Oct 27, 2023
| @@ -86,3 +86,7 @@ require ( | |||
| lukechampine.com/frand v1.4.2 // indirect | |||
| sourcegraph.com/sourcegraph/appdash v0.0.0-20211028080628-e2786a622600 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/pulumi/pulumi/pkg/v3 => github.com/pulumi/pulumi/pkg/v3 v3.78.2-0.20231027181420-202491bfea6a | |||
|
This is looking good. I think we're good to go. |
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated via
$ upgrade-provider pulumi/pulumi-aiven --kind=bridge --target-bridge-version=latest --pr-reviewers=t0yv0 --target-pulumi-version=202491bfea6af05adc505d41a5166e7db9bbdee3.t0yv0 is testing this PR again