Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore UpdateSource errors #96

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Don't ignore UpdateSource errors #96

merged 2 commits into from
Aug 2, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Aug 1, 2024

copyDirectory can currently fail silently, for example if the provided directory doesn't exist.

We should fail in this situation instead of allowing the test to continue with the prior source.

@blampe blampe merged commit 1b678cb into main Aug 2, 2024
2 checks passed
@blampe blampe deleted the blampe/updateSource branch August 2, 2024 21:30
@mjeffryes mjeffryes added this to the 0.108 milestone Aug 16, 2024
@pulumi-bot
Copy link

This PR has been shipped in release v0.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants