Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign windows binaries via makefile #1227

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Sign windows binaries via makefile #1227

merged 3 commits into from
Dec 13, 2024

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Dec 13, 2024 •
edited
Loading

Move the logic for signing windows binaries into the makefile from the CI scripts. This allows testing with signed binaries locally.

  • Fail with error if running in CI so we don't release unsigned binaries. Just warn locally.
  • Add inline documentation explaining how to fix the missing configuration.
  • Allow third party providers to skip signing by having none of the configuration set. Perhaps we could make this more explicit in the future, but that would potentially require changing the config on a bunch of providers - one side or the other.

@danielrbradley
Sign windows binaries via makefile
a21fac8 
Move the logic for signing windows binaries into the makefile from the CI scripts. This allows testing with signed binaries locally.

- Fail with error if running in CI so we don't release unsigned binaries.
- Add inline documentation explaining how to fix the missing configuration.
@danielrbradley danielrbradley requested review from blampe and a team December 13, 2024 16:15
@danielrbradley danielrbradley self-assigned this Dec 13, 2024
@danielrbradley
Allow skipping signing for third party providers
00a23ba 
This is implicit based on all configuration being missing.
t0yv0
t0yv0 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ability to run outside of GHA is always an improvement. A bit heavy for Make in my taste but I'm amenable to where the team wants to take it.

@danielrbradley
Copy link
Member Author

danielrbradley commented Dec 13, 2024 •
edited
Loading

Was a little on the fence about putting into into a bash script to keep the makefile cleaner, but we've not got precedence for that so this felt like the more acceptable change for now. Though, perhaps we should look at that as a follow-up?

@danielrbradley danielrbradley added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit 5f2cfe4 Dec 13, 2024
6 checks passed
@danielrbradley danielrbradley deleted the sign-via-make branch December 13, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ringods ringods ringods approved these changes

@t0yv0 t0yv0 t0yv0 approved these changes

@blampe blampe Awaiting requested review from blampe

Assignees

@danielrbradley danielrbradley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielrbradley @t0yv0 @ringods