Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow root-level go.mod for setup-go caching #1226

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Dec 12, 2024

It is valid (and preferable) to have a root-level go.mod. If one is present we should use it as a cache key for setup-go.

Additionally since there is some talk of moving the SDK's module down a level we might as well handle that case gracefully as well, even if we're not doing it at the moment.

(I would prefer to use **/*.sum, but we don't want Go examples to bust the cache.)

@blampe blampe requested a review from a team December 13, 2024 00:28
@blampe blampe added this pull request to the merge queue Dec 13, 2024
Merged via the queue into master with commit a5f44c8 Dec 13, 2024
6 checks passed
@blampe blampe deleted the blampe/root-go.mod branch December 13, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants