Run registry docs command from correct file location #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few notes on how you tested this would be helpful! |
iwahbe
reviewed
Sep 30, 2024
guineveresaenger
added a commit
to pulumi/pulumi-venafi
that referenced
this pull request
Sep 30, 2024
guineveresaenger
added a commit
to pulumi/pulumi-venafi
that referenced
this pull request
Sep 30, 2024
guineveresaenger
added a commit
to pulumi/pulumi-venafi
that referenced
this pull request
Sep 30, 2024
|
@iwahbe - since this command is behind a flag as per #1083, it has not been run live in CI. I've added a comment to the Make target. |
iwahbe
approved these changes
Sep 30, 2024
guineveresaenger
deleted the
guin/run-installation-from-provider-root
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version was running
makefromproviderfolder. This is the correct location at repo root.edited to add:
This is a followup to #1083. It is not for local development, although it can certainly be used that way.
#1083 was tested against pulumi/pulumi-venafi#433 locally; these changes allow it to run correctly.