Clean up leftover GoReleaser files & config #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielrbradley add the delete of the obsolete files here? ci-mgmt/.github/workflows/update-workflows.yml Lines 70 to 75 in b43c885 |
Yes there or here: https://github.com/pulumi/ci-mgmt/blob/master/provider-ci%2Finternal%2Fpkg%2Fgenerate.go#L78-L87 |
danielrbradley
approved these changes
Sep 9, 2024
guineveresaenger
approved these changes
Sep 10, 2024
This was referenced Sep 10, 2024
ringods
added a commit
to pulumi/pulumi-gcp
that referenced
this pull request
Sep 12, 2024
Remove the flag `skipGoReleaserHooks` from `.ci-mgmt.yml` because support for this was removed a while ago, with the last bits removed in pulumi/ci-mgmt#1074 Change applied based on this section which was removed from https://github.com/pulumi/ci-mgmt/blob/master/provider-ci/internal/pkg/templates/bridged-provider.config.yaml: ``` # Go releaser: skip the post cleaning steps # Only used for gcp: https://github.com/search?q=org%3Apulumi+path%3A.ci-mgmt.yaml+%22skipGoReleaserHooks%3A%22&type=code #skipGoReleaserHooks: false ```
ringods
added a commit
to pulumi/pulumi-minio
that referenced
this pull request
Sep 12, 2024
Remove the flag `skipWindowsArmBuild` from `.ci-mgmt.yml` because support for this was removed a while ago, with the last bits removed in pulumi/ci-mgmt#1074 Change applied based on this section which was removed from https://github.com/pulumi/ci-mgmt/blob/master/provider-ci/internal/pkg/templates/bridged-provider.config.yaml: ``` # Go releaser: add ignore for arm64 windows. # Only used for minio: https://github.com/search?q=org%3Apulumi+path%3A.ci-mgmt.yaml+%22skipWindowsArmBuild%3A%22&type=code #skipWindowsArmBuild: false ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup last GoReleaser based files & config.