Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline worktreeAllowedChanges #1005

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Jun 26, 2024

This is not needed to be overridden now the rollout is complete.

Only use of override is also no longer needed: https://github.com/search?q=org%3Apulumi+path%3A.ci-mgmt.yaml+%22worktreeAllowedChanges%3A%22&type=code

PR to remove dangling use: pulumi/pulumi-kafka#459

This is not needed to be overridden now the rollout is complete.
@danielrbradley danielrbradley self-assigned this Jun 26, 2024
danielrbradley added a commit to pulumi/pulumi-kafka that referenced this pull request Jun 26, 2024
The default option will now work fine here and this option is being removed in pulumi/ci-mgmt#1005
@danielrbradley danielrbradley requested a review from a team June 26, 2024 10:55
@danielrbradley danielrbradley merged commit 4dedb14 into master Jun 26, 2024
5 checks passed
@danielrbradley danielrbradley deleted the inline-allowed-changes branch June 26, 2024 18:12
danielrbradley added a commit to pulumi/pulumi-kafka that referenced this pull request Jun 26, 2024
1. The default option will now work fine here and this option is being
removed in pulumi/ci-mgmt#1005
2. Remove `publish.goSdk` config. This had no effect as
`publish.goSdk.usePush` defaults to true

Workflows will be re-generated on next nightly CI upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants