Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider upgrades fail to build python sdk with error about venv #1197

Open
VenelinMartinov opened this issue Dec 4, 2024 · 3 comments
Open
Labels
kind/bug Some behavior is incorrect or out of spec needs-repro Needs repro steps before it can be triaged or fixed

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Dec 4, 2024

Observed in pulumi/pulumi-rancher2#604. Provider upgrades seem to fail with an error in build_python:

make build_python
cd sdk/python/ && \
		rm -rf ./bin/ ../python.bin/ && cp -R . ../python.bin && mv ../python.bin ./bin && \
		rm ./bin/go.mod && \
		python3 -m venv venv && \
		./venv/bin/python -m pip install build==1.2.1 && \
		cd ./bin && \
		../venv/bin/python -m build .
Error: [Errno 2] No such file or directory: '/Users/vvm/code/pulumi-rancher2/sdk/python/venv/bin/python3'
make: *** [.make/build_python] Error 1

To repro checkout rancher2 at 43c8d3b and run upgrade-provider

Reverting ci-mgmt to before #1151 unblocked the upgrade.

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 4, 2024
@VenelinMartinov VenelinMartinov added kind/bug Some behavior is incorrect or out of spec and removed needs-triage Needs attention from the triage team labels Dec 4, 2024
@iwahbe iwahbe added p1 A bug severe enough to be the next item assigned to an engineer needs-triage Needs attention from the triage team labels Dec 4, 2024
VenelinMartinov added a commit to pulumi/pulumi-rancher2 that referenced this issue Dec 4, 2024
This PR was generated via `$ upgrade-provider pulumi/pulumi-rancher2
--kind=provider --major`.

---

- Updating major version from 7.1.2 to 8.0.0.
- Updating Java Gen version from 0.17.0 to 0.18.0.
- Upgrading terraform-provider-rancher2 from 5.1.0  to 6.0.0.
	Fixes #604


Had to revert some recent ci-mgmt changes due to
pulumi/ci-mgmt#1197
@danielrbradley
Copy link
Member

Could you link to the job that was throwing the error? The linked upgrade issue only links to upgrade jobs which have failed due to it being a major version upgrade.

@danielrbradley danielrbradley removed the needs-triage Needs attention from the triage team label Dec 4, 2024
@VenelinMartinov
Copy link
Contributor Author

The error showed up when running the upgrade locally with upgrade-provider --major - CI fails due to the major version upgrade

@danielrbradley danielrbradley added the awaiting-feedback Blocked on input from the author label Dec 4, 2024
@VenelinMartinov VenelinMartinov added needs-triage Needs attention from the triage team and removed awaiting-feedback Blocked on input from the author labels Dec 4, 2024
@danielrbradley danielrbradley removed the needs-triage Needs attention from the triage team label Dec 4, 2024
@danielrbradley danielrbradley added needs-repro Needs repro steps before it can be triaged or fixed and removed p1 A bug severe enough to be the next item assigned to an engineer labels Dec 4, 2024
@danielrbradley
Copy link
Member

This doesn't appear to happen when running the make commands directly.

To move this forward we need a repro which doesn't involve running upgrade-provider because that tool requires too much external state. It also seems to cause a bunch of the logs to be missing from the make commands.

github-merge-queue bot pushed a commit that referenced this issue Dec 4, 2024
We need the plugins available at runtime of tfgen for generating
examples etc.

Found while trying to repro #1197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec needs-repro Needs repro steps before it can be triaged or fixed
Projects
None yet
Development

No branches or pull requests

4 participants