Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes upstream #12

Closed
meichthys opened this issue Aug 20, 2022 · 5 comments
Closed

Merge changes upstream #12

meichthys opened this issue Aug 20, 2022 · 5 comments
Labels
wontfix This will not be worked on

Comments

@meichthys
Copy link
Contributor

Any chance you could submit merge requests to the official nextcloud photo app for some of these features?

I know you said that it shares some of the same codebase, but I'm not sure how far things have diverged.

The built in photos app is pretty unusable for reasons you already described.

@pulsejet
Copy link
Owner

pulsejet commented Aug 20, 2022

See #183

No, I'm strongly against this. At least right now, I've two full time jobs and really don't have the time to contribute to something maintained by someone else and argue about every design decision I make. Maybe some day.

Secondly, both apps have their merits. If you don't primarily use Nextcloud for photos (a likely scenario in enterprises like universities), the official photos app is very appropriate rather than this.

@pulsejet pulsejet closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2022
@pulsejet pulsejet added the wontfix This will not be worked on label Sep 10, 2022
@meichthys
Copy link
Contributor Author

meichthys commented Nov 28, 2022

@pulsejet I think we can close this since memories has come so far in the last few weeks. I have no desire to move back to Photos or to have changes merged back. Memories is better off by itself.

@pulsejet
Copy link
Owner

It's closed already, unless we got a GitHub bug haha.

@meichthys
Copy link
Contributor Author

@pulsejet Oops, i think i meant to indicate that we could close this: #183

@pulsejet
Copy link
Owner

I'll leave that open for now. Something like a featured tag won't hurt if we can actually get it; visibility is hard to come by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants