Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape shortcut doesn't work when the info tab is opened #1115

Open
AiroPi opened this issue Apr 3, 2024 · 6 comments
Open

Escape shortcut doesn't work when the info tab is opened #1115

AiroPi opened this issue Apr 3, 2024 · 6 comments
Labels
blocked Needs fix or release upstream bug Something isn't working

Comments

@AiroPi
Copy link

AiroPi commented Apr 3, 2024

Describe the bug
When the 'informations' panel is open, the escape keyboard shortcut don't quit the photo view anymore.

To Reproduce
Open a photo in full screen, click the "informations" button. The escape shortcut doesn't work.

Platform:

  • OS: MacOS 14.4
  • Browser: Arc (Chromium Engine Version 123.0.6312.87)
  • Memories Version: 7.1
  • Nextcloud Version: 28.0.3

Additional context
The shortcut works if the informations tab is not open.

@AiroPi AiroPi added the needs triage To be triaged label Apr 3, 2024
@pulsejet pulsejet added bug Something isn't working and removed needs triage To be triaged labels Apr 4, 2024
@pulsejet pulsejet added this to the 7.2 milestone Apr 4, 2024
pulsejet added a commit that referenced this issue Apr 4, 2024
@AiroPi
Copy link
Author

AiroPi commented Apr 11, 2024

It's fixed now, thanks!

@AiroPi AiroPi closed this as completed Apr 11, 2024
@AiroPi
Copy link
Author

AiroPi commented Apr 11, 2024

Ok, it seems that it is not totally fixed. If we view a photo and then open the info tab, the esc shortcut works. If we view a photo with the info tab already enabled, the esc shortcut also works.
But if we have the info tab opened, and we switch to another photo with a an arroy key, the esc shortcut doesn't work.

@AiroPi AiroPi reopened this Apr 11, 2024
@pulsejet
Copy link
Owner

The upstream patch just got merged, we still need to migrate to the new version

@AiroPi
Copy link
Author

AiroPi commented Apr 11, 2024

Ok then some cases were already working as expected before the patch and I didn't notice, my bad

@pulsejet
Copy link
Owner

Hmm so this is actually not in our hands, the patch needs to be used upstream (in nextcloud/server) before it becomes effective. Guess theres not much to do but wait.

@pulsejet pulsejet removed this from the 7.3 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Needs fix or release upstream bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants