-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape shortcut doesn't work when the info tab is opened #1115
Comments
Signed-off-by: Varun Patil <[email protected]>
It's fixed now, thanks! |
Ok, it seems that it is not totally fixed. If we view a photo and then open the info tab, the esc shortcut works. If we view a photo with the info tab already enabled, the esc shortcut also works. |
The upstream patch just got merged, we still need to migrate to the new version |
Ok then some cases were already working as expected before the patch and I didn't notice, my bad |
Hmm so this is actually not in our hands, the patch needs to be used upstream (in |
Describe the bug
When the 'informations' panel is open, the escape keyboard shortcut don't quit the photo view anymore.
To Reproduce
Open a photo in full screen, click the "informations" button. The escape shortcut doesn't work.
Platform:
Additional context
The shortcut works if the informations tab is not open.
The text was updated successfully, but these errors were encountered: