Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree-sitter fixes for December (including a PHP grammar!) #852

Merged

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    a8f5b17 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a1e9fa0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    daf0637 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    818d204 View commit details
    Browse the repository at this point in the history
  5. [tree-sitter] Ruby fixes…

    * Show `def self.foo` methods as `self.foo` in the symbols list.
    * Highlight the `foo` in `def self.foo` as a method name.
    * Properly highlight `..` and `...` range operators.
    * Highlight keyword parameters as `variable.parameter.keyword`.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    037377a View commit details
    Browse the repository at this point in the history
  6. [tree-sitter] Fix indentation hinting at the edges of injections

    When the cursor is placed right where an injection _starts_, and the user presses Return, we usually shouldn't use the injection layer for hinting.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    1ed79e2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fdc70fc View commit details
    Browse the repository at this point in the history
  8. Allow suggestedIndentForBufferRows to work correctly…

    …when auto-indenting the entire buffer.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    20a64bd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    be37b26 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f6bb61f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    da10036 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    bc55c4f View commit details
    Browse the repository at this point in the history
  13. (oops)

    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    7b4a50d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    66aea45 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    294134c View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    ee54d37 View commit details
    Browse the repository at this point in the history
  17. Add a modern Tree-sitter PHP grammar

    This one’s got all the frills, including injections into HTML documents and a PHPDoc grammar.
    
    As part of this change, we're also migrating to `web-tree-sitter` version 0.20.8 with some customizations. The PR I submitted at tree-sitter/tree-sitter#2795 is landed on this fork, though if the same issues get fixed in a different way on the source, I'll adopt that approach as well. The PHPDoc parser needed another external added.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d6f8a3c View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    00de52c View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    1dc1536 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    0fd47f5 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    ee3f41e View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    3a4b2dc View commit details
    Browse the repository at this point in the history
  23. [tree-sitter] TS: Treat parameters with defaults like parameters…

    …plus a few other TypeScript fixes.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    8ae599f View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    b6d88a5 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    18788c0 View commit details
    Browse the repository at this point in the history
  26. Apply PHPDoc learnings to JSDoc

    The conventions I had in place for various JSDoc constructs didn't make any sense. They're fixed now.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    f6e1a22 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    5e62e20 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    0807dcf View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    bbf4cb4 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    351493f View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    bf039cc View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    ebd0ae0 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    e2da555 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    70b34cd View commit details
    Browse the repository at this point in the history
  35. Allow (#set! capture.final) as shorthand…

    …instead of making grammars specify `(#set! capture.final true)`.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    a40bae4 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    30f696f View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    9db2ace View commit details
    Browse the repository at this point in the history
  38. [tree-sitter] Fix indentation hinting at the edges of injections

    When the cursor is placed right where an injection _starts_, and the user presses Return, we usually shouldn't use the injection layer for hinting.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    0e8fe9b View commit details
    Browse the repository at this point in the history
  39. Allow suggestedIndentForBufferRows to work correctly…

    …when auto-indenting the entire buffer.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    a42d0ed View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    d32bdf6 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    d9f6946 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    0b51a77 View commit details
    Browse the repository at this point in the history
  43. (oops)

    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    aef7c84 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    b7dc654 View commit details
    Browse the repository at this point in the history
  45. Add a modern Tree-sitter PHP grammar

    This one’s got all the frills, including injections into HTML documents and a PHPDoc grammar.
    
    As part of this change, we're also migrating to `web-tree-sitter` version 0.20.8 with some customizations. The PR I submitted at tree-sitter/tree-sitter#2795 is landed on this fork, though if the same issues get fixed in a different way on the source, I'll adopt that approach as well. The PHPDoc parser needed another external added.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d148a73 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    c93bdeb View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    ad8a215 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    58b9cc1 View commit details
    Browse the repository at this point in the history
  49. [tree-sitter] TS: Treat parameters with defaults like parameters…

    …plus a few other TypeScript fixes.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    8c946a0 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    f2dabe5 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    2580642 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    8836be7 View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    0b08306 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    336f609 View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    c50b0e6 View commit details
    Browse the repository at this point in the history
  56. Ensure indentation decisions consult the correct layers…

    …when straddling injection boundaries.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    4c6b0ba View commit details
    Browse the repository at this point in the history
  57. Oops

    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    254440e View commit details
    Browse the repository at this point in the history
  58. Update tree-sitter-json WASM build to latest

    Spotted it falling down on a very large JSON file I had. Seems to be fixed on `master`. Not sure which verison I originally built it from.
    savetheclocktower committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    50bfa51 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    865153b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ddfa645 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9972245 View commit details
    Browse the repository at this point in the history
  4. In JS/TS, correctly highlight a variable with a default value…

    …when destructuring an array.
    savetheclocktower committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    a34b01b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e78feea View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Configuration menu
    Copy the full SHA
    62bd6cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3be33b View commit details
    Browse the repository at this point in the history
  3. Add folds for PHP

    savetheclocktower committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    bae3689 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6ebdfa0 View commit details
    Browse the repository at this point in the history
  5. PHP feedback

    savetheclocktower committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    0111e13 View commit details
    Browse the repository at this point in the history