-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor getting started (ch1) #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great, just added a few fixes I noticed.
But otherwise we really should loop back to why-pulsar.md
as you are right it's very much still Atom. But that could be done in another more dedicated PR.
Otherwise love this and love the work
docs/docs/launch-manual/sections/getting-started/sections/installing-pulsar.md
Outdated
Show resolved
Hide resolved
docs/docs/launch-manual/sections/getting-started/sections/installing-pulsar.md
Outdated
Show resolved
Hide resolved
docs/docs/launch-manual/sections/getting-started/sections/installing-pulsar.md
Outdated
Show resolved
Hide resolved
docs/docs/launch-manual/sections/getting-started/sections/installing-pulsar.md
Outdated
Show resolved
Hide resolved
docs/docs/launch-manual/sections/getting-started/sections/installing-pulsar.md
Outdated
Show resolved
Hide resolved
…alling-pulsar.md Co-authored-by: confused_techie <[email protected]>
…alling-pulsar.md Co-authored-by: confused_techie <[email protected]>
…alling-pulsar.md Co-authored-by: confused_techie <[email protected]>
Co-authored-by: confused_techie <[email protected]>
…alling-pulsar.md Co-authored-by: confused_techie <[email protected]>
…alling-pulsar.md Co-authored-by: confused_techie <[email protected]>
Sorry only just noticed this had been reviewed, I've added those suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for making the changes requested, overall this looks great!
Really do on another PR want to take a chance to personalize the why-pulsar.md
but based on your comments you're aware of this to. So lets get this merged for the time being
Yeah, the draft pr from @kaosine has alterations to this section but this one is just meant to be very basic factual alterations to get this content available |
Awesome in that case we can leave the draft as such, since it's still a WIP I won't make this one wait on that. I'll go ahead and merge this one, thanks for contributing! Glad to see you back after the holidays! |
This section was rather out of date as it predated our styleguide and consensus for how to do things. Also predated some of the changes from Atom->Pulsar.
This refactors this section considerably and more importantly re-instates the installation section which will be important for a "v1.0.0" release.
One thing that is still problematic is the pulsar command not working out of the box on many OSs and releases. It would be good if people more familiar with various OSs could create doc PRs or comment somewhere with how we can do this manually so this can be added.
For example see this discord convo and this pulsar enhancement.