Refactor getting started (ch1) #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
docs/docs/launch-manual/sections/getting-started/sections/installing-pulsar.md
Outdated
Show resolved
Hide resolved
docs/docs/launch-manual/sections/getting-started/sections/installing-pulsar.md
Outdated
Show resolved
Hide resolved
docs/docs/launch-manual/sections/getting-started/sections/installing-pulsar.md
Outdated
Show resolved
Hide resolved
docs/docs/launch-manual/sections/getting-started/sections/installing-pulsar.md
Outdated
Show resolved
Hide resolved
docs/docs/launch-manual/sections/getting-started/sections/installing-pulsar.md
Outdated
Show resolved
Hide resolved
…alling-pulsar.md Co-authored-by: confused_techie <[email protected]>
…alling-pulsar.md Co-authored-by: confused_techie <[email protected]>
…alling-pulsar.md Co-authored-by: confused_techie <[email protected]>
Co-authored-by: confused_techie <[email protected]>
…alling-pulsar.md Co-authored-by: confused_techie <[email protected]>
…alling-pulsar.md Co-authored-by: confused_techie <[email protected]>
|
Sorry only just noticed this had been reviewed, I've added those suggestions. |
confused-Techie
approved these changes
Dec 27, 2022
|
Yeah, the draft pr from @kaosine has alterations to this section but this one is just meant to be very basic factual alterations to get this content available |
|
Awesome in that case we can leave the draft as such, since it's still a WIP I won't make this one wait on that. I'll go ahead and merge this one, thanks for contributing! Glad to see you back after the holidays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section was rather out of date as it predated our styleguide and consensus for how to do things. Also predated some of the changes from Atom->Pulsar.
This refactors this section considerably and more importantly re-instates the installation section which will be important for a "v1.0.0" release.
One thing that is still problematic is the pulsar command not working out of the box on many OSs and releases. It would be good if people more familiar with various OSs could create doc PRs or comment somewhere with how we can do this manually so this can be added.
For example see this discord convo and this pulsar enhancement.