Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset size and digests when retrying downloads #2122

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Reset size and digests when retrying downloads #2122

merged 1 commit into from
Jan 20, 2022

Conversation

mdellweg
Copy link
Member

re #2078

@mdellweg mdellweg mentioned this pull request Jan 20, 2022
Merged
@mdellweg mdellweg mentioned this pull request Jan 20, 2022
Closed
dralley
dralley reviewed Jan 20, 2022
View reviewed changes
pulpcore/download/base.py Outdated Show resolved Hide resolved
bmbouter
bmbouter reviewed Jan 20, 2022
View reviewed changes
CHANGES/2135.bugfix Outdated
@@ -0,0 +1 @@
Fixed validation logic in HttpDownloader for retries with partially downloaded files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be rewritten in user terms? Maybe Fixed bug where retries of partially downloaded files failed digest and size validation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmbouter done

bmbouter
bmbouter approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dralley dralley merged commit 6964d77 into pulp:main Jan 20, 2022
@patchback
Copy link

patchback bot commented Jan 20, 2022 •
edited
Loading

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/6964d7772ea7bb75f094b6e5b4227f1602156601/pr-2122

Backported as #2139

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jan 20, 2022
Closed
@patchback
Copy link

patchback bot commented Jan 20, 2022 •
edited
Loading

Backport to 3.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.17/6964d7772ea7bb75f094b6e5b4227f1602156601/pr-2122

Backported as #2140

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jan 20, 2022
Closed
@mdellweg mdellweg deleted the fix_retry branch January 20, 2022 19:23
@fao89
Copy link
Member

fao89 commented May 17, 2022

https://bugzilla.redhat.com/show_bug.cgi?id=2033174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dralley dralley dralley approved these changes

@bmbouter bmbouter bmbouter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdellweg @fao89 @bmbouter @dralley