This repository has been archived by the owner on Oct 28, 2019. It is now read-only.
Replace Distribution with other objects #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
May 9, 2019
The Distribution contained options which should not be mixed. Specifically the repository and repository_version options go together and the publication goes by itself. This PR splits that object into two new objects RepositoryVersionDistribution and PublicationDistribution. Each receives a viewset, serializer, and filterset to match. Each also is a full Detail model and can be used by plugins without additional code from them. Required PR: pulp/pulpcore-plugin#97 Required PR: pulp/pulp_file#219 https://pulp.plan.io/issues/4785 closes pulp#4785
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
May 9, 2019
The Distribution contained options which should not be mixed. Specifically the repository and repository_version options go together and the publication goes by itself. This PR splits that object into two new objects RepositoryVersionDistribution and PublicationDistribution. Required PR: pulp/pulpcore-plugin#97 Required PR: pulp/pulp_file#219 https://pulp.plan.io/issues/4785 closes pulp#4785
bmbouter
changed the title
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
May 9, 2019
The Distribution contained options which should not be mixed. Specifically the repository and repository_version options go together and the publication goes by itself. This PR splits that object into two new objects RepositoryVersionDistribution and PublicationDistribution. The two models are not detail objects, and require the plugin writer to declare a Distribution detail object. It was already this way before this PR. Required PR: pulp/pulpcore-plugin#97 Required PR: pulp/pulp_file#219 https://pulp.plan.io/issues/4785 closes pulp#4785
bmbouter
force-pushed
the
split-distribution
branch
2 times, most recently
from
c7acccd to
1ffed2c
Compare
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
May 9, 2019
The Distribution contained options which should not be mixed. Specifically the repository and repository_version options go together and the publication goes by itself. This PR splits that object into two new objects RepositoryVersionDistribution and PublicationDistribution. The two models are not detail objects, and require the plugin writer to declare a Distribution detail object. It was already this way before this PR. This also adds a release note about the breaking changes that come with the switch to Master/Detail. Required PR: pulp/pulpcore-plugin#97 Required PR: pulp/pulp_file#219 https://pulp.plan.io/issues/4785 closes pulp#4785
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
May 9, 2019
The Distribution contained options which should not be mixed. Specifically the repository and repository_version options go together and the publication goes by itself. This PR splits that object into two new objects RepositoryVersionDistribution and PublicationDistribution. The two models are not detail objects, and require the plugin writer to declare a Distribution detail object. It was already this way before this PR. This also adds a release note about the breaking changes that come with the switch to Master/Detail. Required PR: pulp/pulpcore-plugin#97 Required PR: pulp/pulp_file#219 https://pulp.plan.io/issues/4785 closes pulp#4785
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
May 9, 2019
The Distribution contained options which should not be mixed. Specifically the repository and repository_version options go together and the publication goes by itself. This PR splits that object into two new objects RepositoryVersionDistribution and PublicationDistribution. The two models are not detail objects, and require the plugin writer to declare a Distribution detail object. It was already this way before this PR. This also adds a release note about the breaking changes that come with the switch to Master/Detail. Required PR: pulp/pulpcore-plugin#97 Required PR: pulp/pulp_file#219 https://pulp.plan.io/issues/4785 closes pulp#4785
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
======================================
- Coverage 42.6% 42% -0.6%
======================================
Files 22 21 -1
Lines 730 719 -11
======================================
- Hits 311 302 -9
+ Misses 419 417 -2
Continue to review full report at Codecov.
|
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
May 9, 2019
The Distribution contained options which should not be mixed. Specifically the repository and repository_version options go together and the publication goes by itself. This PR splits that object into two new objects RepositoryVersionDistribution and PublicationDistribution. The two models are not detail objects, and require the plugin writer to declare a Distribution detail object. It was already this way before this PR. This also adds a release note about the breaking changes that come with the switch to Master/Detail. Required PR: pulp/pulpcore-plugin#97 Required PR: pulp/pulp_file#219 https://pulp.plan.io/issues/4785 closes pulp#4785
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
May 9, 2019
The Distribution contained options which should not be mixed. Specifically the repository and repository_version options go together and the publication goes by itself. This PR splits that object into two new objects RepositoryVersionDistribution and PublicationDistribution. The two models are not detail objects, and require the plugin writer to declare a Distribution detail object. It was already this way before this PR. This also adds a release note about the breaking changes that come with the switch to Master/Detail. Required PR: pulp/pulpcore-plugin#97 Required PR: pulp/pulp_file#219 https://pulp.plan.io/issues/4785 closes pulp#4785
dkliban
approved these changes
May 9, 2019
Model Changes The Distribution model was replaced with the RepositoryVersionDistribution and PublicationDistribution models. These are both abstract models and are meant to be subclassed further. Serializer Changes The DistributionSerializer is removed and now BaseDistributionSerializer, PublicationDistributionSerializer, and RepositoryVersionDistributionSerializer are here. These can also be further subclassed by plugin writers. ViewSet Changes DistributionViewset is now called BaseDistributionViewSet. No other viewsets are provided. Docs Changes The release notes are updated to indicate the breaking changes. Required PR: pulp/pulpcore#124 Required PR: pulp/pulp_file#219 https://pulp.plan.io/issues/4785 closes #4785
bmbouter
force-pushed
the
split-distribution
branch
from
1ffed2c to
89d82e9
Compare
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
May 10, 2019
The Distribution contained options which should not be mixed. Specifically the repository and repository_version options go together and the publication goes by itself. This PR splits that object into two new objects RepositoryVersionDistribution and PublicationDistribution. The two models are not detail objects, and require the plugin writer to declare a Distribution detail object. It was already this way before this PR. This also adds a release note about the breaking changes that come with the switch to Master/Detail. Required PR: pulp/pulpcore-plugin#97 Required PR: pulp/pulp_file#219 https://pulp.plan.io/issues/4785 closes pulp#4785
daviddavis
pushed a commit
to daviddavis/pulp_file
that referenced
this pull request
May 14, 2019
The plugin API now uses PublicationDistribution which causes pulp_file users to only receive the fields they can actually use. Required PR: pulp/pulpcore#124 Required PR: pulp/pulpcore-plugin#97 https://pulp.plan.io/issues/4785 closes #4785
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model Changes
The Distribution model was replaced with the
RepositoryVersionDistribution and PublicationDistribution models. These
are both abstract models and are meant to be subclassed further.
Serializer Changes
The DistributionSerializer is removed and now
BaseDistributionSerializer, PublicationDistributionSerializer, and
RepositoryVersionDistributionSerializer are here. These can also be
further subclassed by plugin writers.
ViewSet Changes
DistributionViewset is now called BaseDistributionViewSet. No other
viewsets are provided.
Docs Changes
The release notes are updated to indicate the breaking changes.
Required PR: pulp/pulpcore#124
Required PR: pulp/pulp_file#219
https://pulp.plan.io/issues/4785
closes #4785