Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin template #1940

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Update plugin template #1940

merged 1 commit into from
Feb 22, 2021

Conversation

mdellweg
Copy link
Member

This accommodates for a change in pulpcore that will effect the CI.

pulp/pulpcore#1102

[noissue]

@pulpbot
Copy link
Member

pulpbot commented Feb 18, 2021

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@dralley
Copy link
Contributor

dralley commented Feb 19, 2021

Try rebasing

@mdellweg
Copy link
Member Author

Try rebasing

There's nothing to rebase upon. Trying to rerun.

This accommodates for a change in pulpcore that will effect the CI.

pulp/pulpcore#1102

[noissue]
@mdellweg
Copy link
Member Author

OK, the ALLOWED_CONTENT_CHECKSUMS option was missing in the new template.

@@ -25,6 +25,12 @@ plugin_name: pulp_rpm
plugin_snake: pulp_rpm
publish_docs_to_pulpprojectdotorg: true
pulp_settings:
allowed_content_checksums:
- "sha1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dralley, do we need md5 as well here or do we want to fail if we test any md5 content?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to fail

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@dralley dralley merged commit a03488c into pulp:master Feb 22, 2021
@mdellweg mdellweg deleted the update_plugin branch April 12, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants