-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin template #1940
Update plugin template #1940
Conversation
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
Try rebasing |
There's nothing to rebase upon. Trying to rerun. |
8f5db40
to
b732de9
Compare
This accommodates for a change in pulpcore that will effect the CI. pulp/pulpcore#1102 [noissue]
b732de9
to
4f2a86e
Compare
OK, the |
@@ -25,6 +25,12 @@ plugin_name: pulp_rpm | |||
plugin_snake: pulp_rpm | |||
publish_docs_to_pulpprojectdotorg: true | |||
pulp_settings: | |||
allowed_content_checksums: | |||
- "sha1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dralley, do we need md5 as well here or do we want to fail if we test any md5 content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
This accommodates for a change in pulpcore that will effect the CI.
pulp/pulpcore#1102
[noissue]