Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix APT_BY_HASH setting #985

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix APT_BY_HASH setting #985

merged 1 commit into from
Jan 2, 2024

Conversation

daviddavis
Copy link
Contributor

fixes #984

@daviddavis daviddavis marked this pull request as ready for review December 18, 2023 20:53
quba42
quba42 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@quba42 quba42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I 100% understand why the duplicate/separate import would cause it to not work, but it is certainly cleaner with these changes, and I have full faith that you tested both versions so I am going to approve this.

@quba42
Copy link
Collaborator

quba42 commented Dec 19, 2023

Backporting only to 3.1, since that is the release that adds this feature.

@quba42 quba42 added the .bugfix CHANGES/<issue_number>.bugfix label Dec 19, 2023
@daviddavis
Copy link
Contributor Author

The existing code imports the setting directly from the file which means that it’s always False. This changes it so that it uses django.conf.setting object which allows settings to be overridden by the user.

https://docs.djangoproject.com/en/5.0/topics/settings/#using-settings-in-python-code

@quba42 quba42 merged commit dd67d7e into pulp:main Jan 2, 2024
11 checks passed
@patchback Patchback
Copy link

patchback bot commented Jan 2, 2024 •
edited
Loading

Backport to 3.1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.1/dd67d7e6fdce213ed703683edf1b4b337cb9b17a/pr-985

Backported as #987

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 2, 2024
@quba42 @patchback
Merge pull request #985 from daviddavis/fix984
033fc4a 
Fix APT_BY_HASH setting

(cherry picked from commit dd67d7e)
@patchback patchback bot mentioned this pull request Jan 2, 2024
Merged
quba42 added a commit that referenced this pull request Jan 2, 2024
@quba42
Merge pull request #987 from pulp/patchback/backports/3.1/dd67d7e6fdc…
aa3434a 
…e213ed703683edf1b4b337cb9b17a/pr-985

[PR #985/dd67d7e6 backport][3.1] Fix APT_BY_HASH setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quba42 quba42 quba42 approved these changes

Assignees
No one assigned
Labels
.bugfix CHANGES/<issue_number>.bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting APT_BY_HASH doesn't enable the apt-by-hash feature
2 participants
@daviddavis @quba42