Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add advanced copy mechanism in Pulp3 DEB without dependency_solving #381

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Add advanced copy mechanism in Pulp3 DEB without dependency_solving #381

merged 1 commit into from
Feb 17, 2022

Conversation

Manisha15
Copy link
Contributor

Adds Copy mechanism to be used by Katello to copy content in CV filters

@pulpbot
Copy link
Member

pulpbot commented Dec 27, 2021

WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue.

@quba42
Copy link
Collaborator

quba42 commented Dec 27, 2021

This change needs to add docs here (and possibly elsewhere): https://github.com/pulp/pulp_deb/blob/main/docs/feature_overview.rst

@quba42
Copy link
Collaborator

quba42 commented Dec 27, 2021

I guess this closes the following issue: https://pulp.plan.io/issues/7661

@Manisha15 Manisha15 force-pushed the pulp3_copy_mechanism branch 3 times, most recently from 022ebf5 to 3cb7e55 Compare December 28, 2021 09:44
@quba42 quba42 self-requested a review January 4, 2022 12:33
@Manisha15 Manisha15 force-pushed the pulp3_copy_mechanism branch 9 times, most recently from d2d1d37 to 5f45009 Compare January 19, 2022 09:14
@quba42 quba42 linked an issue Jan 31, 2022 that may be closed by this pull request
As a user I want advanced copy workflows #396
Closed
@Manisha15 Manisha15 force-pushed the pulp3_copy_mechanism branch from dc7da55 to edd2a71 Compare February 14, 2022 10:12
@Manisha15 Manisha15 changed the title Add advanced copy mechanism in Pulp3 Add advanced copy mechanism in Pulp3 DEB without dependency_solving Feb 14, 2022
@Manisha15 Manisha15 force-pushed the pulp3_copy_mechanism branch 7 times, most recently from 99a979b to d8c8211 Compare February 15, 2022 12:32
@quba42 quba42 marked this pull request as ready for review February 15, 2022 15:18
@quba42 quba42 force-pushed the pulp3_copy_mechanism branch from d8c8211 to 4dbea9d Compare February 16, 2022 15:19
quba42
quba42 requested changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@quba42 quba42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the requested changes are small nitpicks in docstring wording or naming.
I would make one substantive addition to the _process_config function.

Once that is done, this should be very much nearing completion.

CHANGES/396.feature Outdated Show resolved Hide resolved
pulp_deb/app/serializers/__init__.py Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
pulp_deb/app/viewsets/repository.py Outdated Show resolved Hide resolved
pulp_deb/app/serializers/repository_serializers.py Show resolved Hide resolved
pulp_deb/app/serializers/repository_serializers.py Outdated Show resolved Hide resolved
pulp_deb/app/viewsets/repository.py Outdated Show resolved Hide resolved
pulp_deb/app/viewsets/repository.py Outdated Show resolved Hide resolved
pulp_deb/app/tasks/copy.py Show resolved Hide resolved
@Manisha15 Manisha15 force-pushed the pulp3_copy_mechanism branch from 4dbea9d to 92a54b4 Compare February 17, 2022 12:27
quba42
quba42 reviewed Feb 17, 2022
View reviewed changes
CHANGES/396.feature Outdated Show resolved Hide resolved
@Manisha15 Manisha15 force-pushed the pulp3_copy_mechanism branch 3 times, most recently from f0f53a3 to 385d91d Compare February 17, 2022 15:37
quba42
quba42 requested changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@quba42 quba42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly done!

pulp_deb/app/tasks/copy.py Outdated Show resolved Hide resolved
pulp_deb/app/tasks/copy.py Outdated Show resolved Hide resolved
@Manisha15 Manisha15 force-pushed the pulp3_copy_mechanism branch 2 times, most recently from 01565f1 to 4a2a8c0 Compare February 17, 2022 16:24
quba42
quba42 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@quba42 quba42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very cool feature, with lots of potential for further improvements on top of it/using similar techniques!

@Manisha15 Manisha15 force-pushed the pulp3_copy_mechanism branch from 4a2a8c0 to 82acce3 Compare February 17, 2022 16:27
@quba42 quba42 force-pushed the pulp3_copy_mechanism branch from 82acce3 to 2616e22 Compare February 17, 2022 16:36
@quba42 quba42 mentioned this pull request Feb 17, 2022
Open
@quba42
Copy link
Collaborator

quba42 commented Feb 17, 2022

I added some minimal "feature overview" documentation.
A full workflow documentation will not be added until there are pulp-cli-deb commands for this feature, and we find the time to write that documentation.

To that end: pulp/pulp-cli-deb#22

@quba42 quba42 merged commit 14510e5 into pulp:main Feb 17, 2022
@quba42 quba42 deleted the pulp3_copy_mechanism branch February 17, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quba42 quba42 quba42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a user I want advanced copy workflows
3 participants
@Manisha15 @pulpbot @quba42