Improve queries in publish task to utilize select_related #1114
Conversation
hstct
force-pushed
the
improve_publish_queries
branch
9 times, most recently
from
c128333 to
a32953f
Compare
There was a problem hiding this comment.
The changes look very clean to me, and I can see how they would dramatically improve query performance! The only thing I am not sure about is the select_related("release", "distribution") on ReleaseComponents. Can we double check if that actually does anything? If not it should be dropped.
Also, using release_components_filtered to create the list of components and the prcs looks like a bugfix to me. Was this correct before?!
hstct
force-pushed
the
improve_publish_queries
branch
from
a32953f to
6c281cb
Compare
Backport to 3.2: 💚 backport PR created✅ Backport PR branch: Backported as #1129 🤖 @patchback |
Backport to 3.3: 💚 backport PR created✅ Backport PR branch: Backported as #1130 🤖 @patchback |
Improve queries in publish task to utilize select_related (cherry picked from commit b29542e)
Improve queries in publish task to utilize select_related (cherry picked from commit b29542e)
…b547fec1c8607148fda51e65d9b99e/pr-1114 [PR #1114/b29542e8 backport][3.2] Improve queries in publish task to utilize select_related
…b547fec1c8607148fda51e65d9b99e/pr-1114 [PR #1114/b29542e8 backport][3.3] Improve queries in publish task to utilize select_related
closes #1115