Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing packages from structured publications leaves dangling PRCs #1190

Closed
hstct opened this issue Nov 20, 2024 · 1 comment · Fixed by #1185
Closed

Removing packages from structured publications leaves dangling PRCs #1190

hstct opened this issue Nov 20, 2024 · 1 comment · Fixed by #1185
Labels
.bugfix CHANGES/<issue_number>.bugfix

Comments

@hstct
Copy link
Contributor

hstct commented Nov 20, 2024

Describe the bug
When removing a package from a repository via the /pulp/api/v3/repositories/deb/apt/modify/ endpoint in a structured publication, the corresponding package release component (PRC) file that references the removed package is not removed as expected.

To Reproduce

  1. Sync a remote repository to create the initial repository version.
  2. Use the /pulp/api/v3/repositories/deb/apt/modify/ endpoint to remove a specific package from the repository.
  3. Inspect the latest repository version and verify that the PRC referencing the removed package is still present in the content units.

Expected behavior
When a package is removed via the modify endpoint, the PRC file referencing the package's href should also be removed from the repository version to ensure consistency.

hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Nov 20, 2024
hstct added a commit to ATIX-AG/pulp_deb that referenced this issue Nov 20, 2024
@quba42 quba42 added .bugfix CHANGES/<issue_number>.bugfix and removed Triage-Needed labels Nov 20, 2024
@quba42
Copy link
Collaborator

quba42 commented Nov 20, 2024

Just wanted to expand on why this is a problem: On the publish using structured mode, pulp_deb will loop over the dangling PRC, and pull the removed package back in. This means the published repo will contain the package that the user explicitly removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.bugfix CHANGES/<issue_number>.bugfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants