Adds workaround for requires_ansible
#811
Conversation
|
Actually I want to add a test for this collection.... Let me add that test now. |
| @@ -1046,7 +1046,9 @@ def _post_save(self, batch): | |||
| ) | |||
| if runtime_metadata: | |||
| runtime_yaml = yaml.safe_load(runtime_metadata) | |||
| collection_version.requires_ansible = runtime_yaml.get("requires_ansible") | |||
| if runtime_yaml: | |||
| collection_version.requires_ansible = runtime_yaml.get( | |||
There was a problem hiding this comment.
Assuming its save to leave this field empty.
There was a problem hiding this comment.
I think it has to be based on what @awcrosby is saying #806 (comment)
bmbouter
force-pushed
the
add-requires-ansible-workaround
branch
from
98117a8 to
e2412ae
Compare
| @@ -134,6 +134,22 @@ def test_sync_with_invalid_requirements(self): | |||
| ) | |||
| self.assertRaises(ApiException, self.remote_collection_api.create, body) | |||
|
|
|||
| def test_sync_collection_missing_requires_ansible(self): | |||
There was a problem hiding this comment.
I confirmed this test fails with the error I experienced without the fix. Then it passes with the fix.
Collections on galaxy.ansible.com may not have the expected `requires_ansible` data. closes pulp#806
bmbouter
force-pushed
the
add-requires-ansible-workaround
branch
from
e2412ae to
32a1238
Compare
Backport to 0.11: 💚 backport PR created✅ Backport PR branch: Backported as #814 🤖 @patchback |
Backport to 0.10: 💚 backport PR created✅ Backport PR branch: Backported as #815 🤖 @patchback |
Backport to 0.7: 💚 backport PR created✅ Backport PR branch: Backported as #816 🤖 @patchback |
Collections on galaxy.ansible.com may not have the expected
requires_ansibledata.closes #806