Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow GitRemotes on AnsibleRepositories #1336

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Allow GitRemotes on AnsibleRepositories #1336

merged 1 commit into from
Jan 24, 2023

Conversation

gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Jan 23, 2023

fixes: #1140

mdellweg
mdellweg approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks obvious.
Are the remote types not checked on sync? I think we should do that.

@gerrod3
Copy link
Contributor Author

gerrod3 commented Jan 24, 2023

Looks obvious. Are the remote types not checked on sync? I think we should do that.

No, we have an issue for it in pulpcore: pulp/pulpcore#1860

@gerrod3 gerrod3 merged commit 5778d86 into pulp:main Jan 24, 2023
@gerrod3 gerrod3 deleted the git-remote-attach branch January 24, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git Remotes can not be attached to an Ansible Repository
2 participants
@gerrod3 @mdellweg