-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signing task doesn't properly use the MANIFEST.json file for the signature creation. #841
Labels
Comments
gerrod3
added a commit
to gerrod3/pulp_ansible
that referenced
this issue
Feb 23, 2022
Merged
gerrod3
added a commit
to gerrod3/pulp_ansible
that referenced
this issue
Feb 23, 2022
gerrod3
added a commit
to gerrod3/pulp_ansible
that referenced
this issue
Feb 23, 2022
gerrod3
added a commit
to gerrod3/pulp_ansible
that referenced
this issue
Feb 23, 2022
gerrod3
added a commit
to gerrod3/pulp_ansible
that referenced
this issue
Feb 23, 2022
gerrod3
added a commit
to gerrod3/pulp_ansible
that referenced
this issue
Feb 23, 2022
gerrod3
added a commit
to gerrod3/pulp_ansible
that referenced
this issue
Feb 23, 2022
gerrod3
added a commit
to gerrod3/pulp_ansible
that referenced
this issue
Feb 24, 2022
gerrod3
added a commit
to gerrod3/pulp_ansible
that referenced
this issue
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
pulpcore 3.17+, ansible- 0.12.0
Describe the bug
The current implementation of the signature task doesn't properly extract the current MANIFEST.json file from the collection tarball and use that to create that collection's signature. Instead it uses the manifest field on the collection-version's model and dumps the json to a temporary file and signs that. However, the json dumping of the manifest field could create a file with completely different formatting compared to the original MANIFEST.json file and thus produce an invalid signature. The signature task should use the exact MANIFEST.json file that the ansible-galaxy-cli will use for its verification.
The text was updated successfully, but these errors were encountered: