Serializer.validate must return validated data. Fixes #1441 (#1432)

(cherry picked from commit 69e2017)
pulp · May 10, 2023 · dba8dd1 · dba8dd1
1 parent 91dd577
commit dba8dd1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/CHANGES/1441.bugfix b/CHANGES/1441.bugfix
@@ -0,0 +1 @@
+Fix traceback when publishing a collection to the v2 API endpoint
diff --git a/functest_requirements.txt b/functest_requirements.txt
@@ -1,4 +1,5 @@
 pulp-smash @ git+https://github.com/pulp/pulp-smash.git
+ansible-core!=2.13.9,!=2.14.5
 orionutils
 pytest
 dynaconf
diff --git a/pulp_ansible/app/galaxy/serializers.py b/pulp_ansible/app/galaxy/serializers.py
@@ -191,7 +191,9 @@ class GalaxyCollectionUploadSerializer(serializers.Serializer):
 
     def validate(self, data):
         """Ensure duplicate artifact isn't uploaded."""
+        data = super().validate(data)
         sha256 = data["file"].hashers["sha256"].hexdigest()
         artifact = Artifact.objects.filter(sha256=sha256).first()
         if artifact:
             raise serializers.ValidationError(_("Artifact already exists"))
+        return data
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix traceback when publishing a collection to the v2 API endpoint