-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use oci-env's environment variable to define the default container engine #81
Open
jctanner
wants to merge
4
commits into
pulp:main
Choose a base branch
from
jctanner:CONTAINER_ENGINE_FROM_ENV
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gine. [noissue] Signed-off-by: James Tanner <[email protected]>
gerrod3
previously approved these changes
Oct 25, 2022
ekohl
suggested changes
Oct 26, 2022
[noissue] Signed-off-by: James Tanner <[email protected]>
ekohl
reviewed
Oct 26, 2022
[noissue] Signed-off-by: James Tanner <[email protected]>
ekohl
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks correct. Personally I'd write it much more condensed and drop some obvious comments, but I'm no maintainer on this repo.
[noissue] Signed-off-by: James Tanner <[email protected]>
There's a lot of stuff in this ecosystem that isn't obvious to everyone, especially not me ... so I'm defaulting to as much verbosity as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oci-env sets an COMPOSE_BINARY environment variable for all subprocesses based on the user's config. That will now influnce the build.sh script in this repo to use whatever the user has configured instead of defaulting to podman if found in the path.