Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use oci-env's environment variable to define the default container engine #81

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jctanner
Copy link
Contributor

oci-env sets an COMPOSE_BINARY environment variable for all subprocesses based on the user's config. That will now influnce the build.sh script in this repo to use whatever the user has configured instead of defaulting to podman if found in the path.

gerrod3
gerrod3 previously approved these changes Oct 25, 2022
generate.sh Outdated Show resolved Hide resolved
generate.sh Outdated Show resolved Hide resolved
[noissue]

Signed-off-by: James Tanner <[email protected]>
generate.sh Outdated Show resolved Hide resolved
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner jctanner requested a review from ekohl October 26, 2022 16:03
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks correct. Personally I'd write it much more condensed and drop some obvious comments, but I'm no maintainer on this repo.

generate.sh Outdated Show resolved Hide resolved
[noissue]

Signed-off-by: James Tanner <[email protected]>
@jctanner
Copy link
Contributor Author

There's a lot of stuff in this ecosystem that isn't obvious to everyone, especially not me ... so I'm defaulting to as much verbosity as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants