Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import export support of python content #610

Closed
wants to merge 1 commit into from

Conversation

tjmullicani
Copy link
Contributor

@tjmullicani tjmullicani commented Dec 1, 2022

Review Checklist:

  • An issue is properly linked. [feature and bugfix only]
  • Tests are present or not feasible.
  • Commits are split in a logical way (not historically).

fixes #609

@tjmullicani
Copy link
Contributor Author

tjmullicani commented Dec 1, 2022

requires pulp/pulp_python#580

@@ -71,6 +71,7 @@ class PulpPythonRepositoryContext(PulpRepositoryContext):
ENTITIES = _("python repositories")
ID_PREFIX = "repositories_python_python"
VERSION_CONTEXT = PulpPythonRepositoryVersionContext
CAPABILITIES = {"pulpexport": [PluginRequirement("python")]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to include the version of pulp_python to include this feature.

Copy link
Contributor Author

@tjmullicani tjmullicani Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we have to wait for it to be included in the next pulp_python release.

@tjmullicani tjmullicani force-pushed the add_python_importexport branch 2 times, most recently from 7c8ac47 to a16e770 Compare March 9, 2023 19:40
@tjmullicani tjmullicani force-pushed the add_python_importexport branch from a16e770 to 50f0049 Compare March 9, 2023 19:41
@@ -0,0 +1 @@
Add import export support of python content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add import export support of python content
Added import export support of python content.

CAPABILITIES = {"sync": [PluginRequirement("python")]}
CAPABILITIES = {
"sync": [PluginRequirement("python")],
"pulpexport": [PluginRequirement("python")],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm almost certain, this needs a version dependency (unless it's >=3.1.0).

@mdellweg mdellweg marked this pull request as draft June 21, 2023 13:39
@mdellweg
Copy link
Member

Marking as draft while we wait on the server plugin parts.

We would love to see you coming back on these.

@gerrod3
Copy link
Contributor

gerrod3 commented Feb 14, 2024

Completed in #887

@gerrod3 gerrod3 closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add import export support of python content
3 participants