Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PARTIAL_UPDATE_ID workaround #530

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Fix PARTIAL_UPDATE_ID workaround #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/529.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed the heuristics for the `PARTIAL_UPDATE_ID` workaround.
2 changes: 1 addition & 1 deletion pulpcore/cli/common/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ def update(
non_blocking: bool = False,
) -> Any:
# Workaround for plugins that do not have ID_PREFIX in place
if not hasattr(self, "ID_PREFIX") and not hasattr(self, "PARTIAL_UPDATE_ID"):
if hasattr(self, "UPDATE_ID") and not hasattr(self, "PARTIAL_UPDATE_ID"):
self.PARTIAL_UPDATE_ID = getattr(self, "UPDATE_ID")
# ----------------------------------------------------------
_parameters = {self.HREF: href or self.pulp_href}
Expand Down
2 changes: 1 addition & 1 deletion pulpcore/cli/common/openapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def __init__(
):
if not validate_certs:
# types-urllib3 does not cover that function
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning) # type:ignore
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)

self.debug_callback: Callable[[int, str], Any] = debug_callback or (lambda i, x: None)
self.base_url: str = base_url
Expand Down