-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflows documentation page #404
Conversation
Wow, this looks like a lot of work. |
No, but I was looking into it. I just couldn't decide what would be the best approach.
The big problem I couldn't decide on was how to handle commands that could call different endpoints based on their field options. Wasn't sure what would be the best way to reflect that in an auto-generated table. |
Actually, i am concerned this level of detail may be too much (both for digesting and for keeping up to date). |
Yeah the tables might be a bit much. The other idea I had for the features section was creating a list of objects for each plugin and putting the operations that the CLI can perform on them, e.g. C=Create, R=Read, U=Update, D=Destroy
|
2688bb6
to
d0e778b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to avoid adding html tags.
d0e778b
to
43facc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some testing after our discussions this week, I have two suggestions:
- bold the 'verb' entries, to make them stand out more, so the reader can see at a glance "what's working"
- add this page to mydocs.,yml so it show up in the menu
43facc6
to
044e496
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would still like to see the CRUD indicators in bold, as well as fixing the Workflows-lists.
|
||
### Workflows | ||
|
||
The CLI currently supports the following workflows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This built as a single paragraph for some reason - resulting HTML (at least on my box):
<p>The CLI currently supports the following workflows:
* <a href="https://docs.pulpproject.org/pulpcore/workflows/upload-publish.html"><strong>Uploading</strong> Artifacts</a>
* <a href="https://docs.pulpproject.org/pulpcore/workflows/exposing-content.html"><strong>Creating, Syncing, Distributing</strong> Content</a>
* <a href="https://docs.pulpproject.org/pulpcore/workflows/import-export.html#exporting"><strong>Exporting</strong> Content</a>
* <a href="https://docs.pulpproject.org/pulpcore/workflows/labels.html"><strong>Labeling</strong> Resources</a></p>
|
||
### Workflows | ||
|
||
The CLI currently supports the following workflows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here as above - in fact, all the Workflows sections. I think they need a blank line before the lists?
My bad, I wasn't thinking of the CRUD indicators as verbs. Should the letters in the keys also be bolded? |
Hm - I'm not sure we need to. What I'm mostly after here, is to pull the eye to the end of the line and separate the "these are implemented" from "this is the object" - does that make sense? |
044e496
to
de73450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great, thanks!
Thanks @gerrod3 !! @mdellweg with the addition of |
Yes it is up to the plugin writers to change their workflows to use the CLI. Currently |
Yes - OK - Great! |
fixes: #395