Add href support to resource_option

[mdellweg]

fixes #315

[mdellweg]

This is currently only implemented in "pulp file repository *" commands to showcase.

[daviddavis]

I wonder if this should check for href_pattern instead and then just assume it's a name if it doesn't match:

$ pulp file remote create --name /test/ --url https://fixtures.pulpproject.org/file/
$ pulp file repository create --name /test/ --remote /test/
Error: '/test/' is not a valid href for remote.

[mdellweg]

That wouldn't solve the problem where the name actually looks like a valid href.
But you can always use: $ pulp file repository create --name /test/ --remote ::/test/

[mdellweg]

@daviddavis I extended the use of this feature to all plugins sync and export{,er}s. You might want to revisit.

[daviddavis]

I had one thought (not necessarily for this PR): what if we stored the href_pattern on the context instead of having to define it everywhere?

[mdellweg]

I had one thought (not necessarily for this PR): what if we stored the href_pattern on the context instead of having to define it everywhere?

I'm happy to move it around (to generic?). But for the more generic options, what should be the Context to store it on?

[daviddavis]

Maybe for generic options, the href_pattern must be supplied when calling resource_option?

[mdellweg]

I moved it into the base context. It seemd to match best there.

[daviddavis]

Why define this here instead of using PulpRepositoryContext.HREF_PATTERN?

[mdellweg]

forgot about that.

[daviddavis]

I was thinking that _option_callback in resource_option would have some logic like:

if href_pattern is None and hasattr(ctx, HREF_PATTERN):
    href_pattern = ctx.HREF_PATTERN

[mdellweg]

I was thinking that _option_callback in resource_option would have some logic like:

if href_pattern is None and hasattr(ctx, HREF_PATTERN):
    href_pattern = ctx.HREF_PATTERN

The problem is, it needs the pattern before determining the Context class to instanciate.

[daviddavis]

Ah, I see. That kind of defeats part of the purpose of my suggestion to have it on context then.

[mdellweg]

Ah, I see. That kind of defeats part of the purpose of my suggestion to have it on context then.

It still feels like the right place.