Fixed crashing pulp domain

Providing a default value for --domain lead to the domain subcommand group getting an invalid default_map. fixes #769 (cherry picked from commit aa48741)
pulp · Aug 11, 2023 · 53c0ea3 · 53c0ea3
1 parent 36a6df3
commit 53c0ea3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGES/769.bugfix b/CHANGES/769.bugfix
@@ -0,0 +1 @@
+Fixed a crash in `pulp domain` when a default value for `--domain` was provided in the config file.
diff --git a/pulpcore/cli/core/domain.py b/pulpcore/cli/core/domain.py
@@ -21,7 +21,9 @@
 _ = translation.gettext
 
 
-@pulp_group()
+# We need to override the default_map, because we may read a default value for the `--domain`
+# option from the config file that will collide here.
+@pulp_group(name="domain", context_settings={"default_map": {}})
 @pass_pulp_context
 @click.pass_context
 def domain(ctx: click.Context, pulp_ctx: PulpContext) -> None:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixed a crash in `pulp domain` when a default value for `--domain` was provided in the config file.