Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable azure tests #502

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Enable azure tests #502

merged 1 commit into from
Sep 23, 2021

Conversation

fao89
Copy link
Member

@fao89 fao89 commented Sep 21, 2021

closes #501

Comment on lines +33 to +35
{%- if test_azure %}
- TEST: azure
{%- endif %}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking about only enabling it at nightly job

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say, new tests should run more often. What they are supposed to test is probably a hot area of code change. Once you are confident about them, you can move them to nightly only.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried about the CI load, but I agree with you

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I would like to see it in action.

Comment on lines +33 to +35
{%- if test_azure %}
- TEST: azure
{%- endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say, new tests should run more often. What they are supposed to test is probably a hot area of code change. Once you are confident about them, you can move them to nightly only.

sudo dpkg-reconfigure ca-certificates
cd ..
sed -i -e '/^services:/a \
- name: pulp-azurite\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As if we build our own docker compose. ;)

@fao89
Copy link
Member Author

fao89 commented Sep 22, 2021

Looks good so far. I would like to see it in action.

pulp/pulp_ansible#649

@fao89 fao89 merged commit 88bcdd3 into pulp:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As plugin writer, I can test azure storage
2 participants