-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable azure tests #502
Enable azure tests #502
Conversation
{%- if test_azure %} | ||
- TEST: azure | ||
{%- endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been thinking about only enabling it at nightly job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say, new tests should run more often. What they are supposed to test is probably a hot area of code change. Once you are confident about them, you can move them to nightly only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was worried about the CI load, but I agree with you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. I would like to see it in action.
{%- if test_azure %} | ||
- TEST: azure | ||
{%- endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say, new tests should run more often. What they are supposed to test is probably a hot area of code change. Once you are confident about them, you can move them to nightly only.
sudo dpkg-reconfigure ca-certificates | ||
cd .. | ||
sed -i -e '/^services:/a \ | ||
- name: pulp-azurite\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As if we build our own docker compose. ;)
|
closes pulp#501
closes #501